#258 new
Vitaly Krjacko

Skype links are malformed

Reported by Vitaly Krjacko | May 23rd, 2012 @ 06:51 AM | in 0.9.10 "Alekhine"

Hi all,

in application_helper.rb the skype link is made as a http:// here:
def web_presence_icons(person)

[ :blog, :linkedin, :facebook, :twitter, :skype ].map do |site|
  url = person.send(site)
  unless url.blank?
    url = "http://" << url unless url.match(/^https?:\/\//)
    link_to(image_tag("#{site}.gif", :size => "15x15"), url, :"data-popup" => true, :title => t(:open_in_window, url))
  end
end.compact.join("\n").html_safe

end

For a quick fix should be extended with something like:
if site == :skype then

url = "callto://" << url

else

url = "http://" << url unless url.match(/^https?:\/\//)

end

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Ruby on Rails CRM platform for Web 2.0 and beyond

People watching this ticket

Pages