Comments and changes to this ticket

• You flagged this item as spam.
  

  Thomas March 23rd, 2013 @ 07:47 AM

  Same problem here.
  I don't speak ruby, but based on John's report, I commented out one line in app/models/polymorphic/comment.rb, see below.
  Now it works.
  Obviously, FFCRM tried to send a notification about the new comment to the first user who left a comment, and this didn't work. Probably due to a misconfiguration of the email settings.
  It would be a good idea to check the settings in FFCRM and display an error message in case of mistakes.

  # Notify subscribed users when a comment is added, unless user created this comment def notify_subscribers commentable.subscribed_users.reject{|user_id| user_id == user.id}.each do |subscriber_id| if subscriber = User.find_by_id(subscriber_id) # Only send email if SMTP settings are configured if Rails.application.config.action_mailer.smtp_settings.present?

  SubscriptionMailer.comment_notification(subscriber, self).deliver <--- commented out here, just to make it work

      end
    end
  end
  

  end

• You flagged this item as spam.
  

  Thomas March 23rd, 2013 @ 07:52 AM

  Sorry, I wasn't aware that '#' is used to define captions here.
  One more try.

    # Notify subscribed users when a comment is added, unless user created this comment
    def notify_subscribers
      commentable.subscribed_users.reject{|user_id| user_id == user.id}.each do |subscriber_id|
        if subscriber = User.find_by_id(subscriber_id)
          # Only send email if SMTP settings are configured
          if Rails.application.config.action_mailer.smtp_settings.present?
  #          SubscriptionMailer.comment_notification(subscriber, self).deliver
          end
        end
      end
    end
  

• You flagged this item as spam.
  

  Thomas March 23rd, 2013 @ 09:18 AM

  Works alright after I corrected my email settings in settings.yml for comments.

• You flagged this item as spam.
  

  John Chase March 23rd, 2013 @ 10:16 AM

  Thanks for the reply. +1

  I did get this working by removing the < / > from the subject line. See below.

  git diff app/mailers/subscription_mailer.rb
  diff --git a/app/mailers/subscription_mailer.rb b/app/mailers/subscription_mailer.rb
  index 96260e4..a79f58f 100644
  --- a/app/mailers/subscription_mailer.rb +++ b/app/mailers/subscription_mailer.rb @@ -31,7 +31,7 @@ class SubscriptionMailer < ActionMailer::Base

   mail :subject => subject,
        :to => user.email,
  

  • :from => "#{@user.full_name} <#{Setting.email_comment_replies[:address]}>",
  • :from => "#{@user.full_name} #{Setting.email_comment_replies[:address]}", :date => Time.now end end